Operator initializer and finalizer for challenge #124
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Adding operator files and initial CRD generator * Added more CRD fields * CRD generator mostly configured * Changed deployed to spec and brought PersistentVolumeClaim to challenge spec * Basic code for the controller, but there are still somethings to be reviewed. Also, changed int to int32, so it matches DeploymentSpec. * Updated CRD generator and coded partially operator behaviour. Also updated CRDs and the CR example for now. * Organized the code and corrected where to set some default values (ports, persistent volume claim and deployment). * Adding some comments to the code. * Fixing a comment misplaced. * Fixing ports and organizing more the code. Also added the creation of a service. * Changing some things, adding more configurations to the deploymeny and solving some problems found while testing * Fixed these issues. HTTP isn't implemented yet but I left a TODO and it will be implemented next * Added HTTPS support as an protocol and fixed container ports in deployment. * Fixing Autoscaling. * Renamed autoscaling and changed some Specs to pointers. * Added watches and TODO * Didn't send this file in the last commit
* Adding default for PodTemplate and PersistentVolumeClaim. Also adding some configurations of the deployment. * Solved a problem with RBAC control. Cleaned more the code from challenge_controller.go. Changed controller to watch all namespaces. Created a README.md with informations about how to run the operator. Created as well images in quay.io for testing with the operator and with real challenges. * Update README.md * Cleaning challenge_controller.go by creating functions that create and delete the objects. * Fixing README.md and challenge_default.go by removing default values of PodTemplate and PersistentVolumeClaim
… name of the package to resources. Created initial structure of initializer and finalizer for the challenge. Changed operator's namespace to kube-system.
…e. Still need to implement the clean up of the persistent volume claim.
…to create a namespace for the challenge before creating it. Thus I added a condition to check if the namespace is the same as the name and if it isn't default because if it is, the object can't be finalized.
|
Wrong branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now the operator creates some initial features that are necessary for the kctf (apparmor and etc) and then it starts watching the challenges.
I also added a finalizer that erases the namespace when the challenge is deleted. As we do that, I added a condition that only accepts namespaces equal the name and rejects a namespace equal default (should we add other namespaces that are forbidden?).
It wasn't possible to add a initializer for the challenge to create the namespace because the namespace has to be created before the challenge is created.