Creation of packages and full implementation of updates for services, autoscaling and deployment #126
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the operator anymore. Passed creation of service and autoscaling to update and now it checks if there was a change inside these structures in the challenge declaration and updates the k8s objects.
…completed. There are two new packages: volumes and pow. Volumes will contain functions responsible for the creation of the persistent volume claim and persistent volume. Pow will contain the functions responsible to create the configmap and etc.
gree-gorey
reviewed
Aug 18, 2020
kctf-operator/pkg/controller/challenge/autoscaling/functions.go
Outdated
Show resolved
Hide resolved
kctf-operator/pkg/controller/challenge/autoscaling/horizontal-pod-autoscaler.go
Outdated
Show resolved
Hide resolved
kctf-operator/pkg/controller/challenge/deployment/deployment-with-healthcheck.go
Outdated
Show resolved
Hide resolved
gree-gorey
reviewed
Aug 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most of the changes here were simply the creation of the packages and the implementation of updates (not necessarily creation or deletion, but if the author changes only a field and then the object needs to be updated).
Created too the structure for pow and the volumes but it's not implemented yet.
Deleted the finalizer: it will no longer be needed. We can clean the persistent volume with simply one configuration. It's not necessary to create a controller for this.
Small problem: Realized that the problem of creating the CRD with the pod template still is a problem. But if we erase two problematic lines in the CRD, the problem is solved. The bad part is that we would always need to do this every time we want to change the structure of the CRD (which might not be such a problem but needs to be documented).
UPDATE: We might still need a finalizer or an additional operator since a standard operator for persistent volumes is not implemented for GCS.