-
Notifications
You must be signed in to change notification settings - Fork 75
Status and Integration with the rest of the code #134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ject is updating/up-to-date-/error and started to implement the Health status. Also, changed some scripts, but still need to finish changing the makefile and checking if everything works.
… have functions that are used by multiple packages. Also changed the crd and challenge_types.go to make the image for the challenge not required: the reason behind that is that we will keep the way we pass the docker images since an kctf-sdk won't be implemented now, but in the future.
…k. Fixed a small issue with deployed.
…an error if it already exists in the cluster). Also, deleted useless parts of batch-deploy.sh
…ted to the deployment and the service. Finished implementation of the two status: Health and Status, which contain useful information about the pods.
…l the samples and the base directory.
sroettger
reviewed
Sep 2, 2020
sroettger
reviewed
Sep 2, 2020
sroettger
reviewed
Sep 2, 2020
sroettger
approved these changes
Sep 2, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cool, looks good. Just a few comments.
…ction that find the index of a container with a specific name.
sirdarckcat
approved these changes
Sep 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed the scripts/makefile/code so the operator is integrated with everything else. I also created two status: Health and Status. The first one says if the challenge is healthy and the second one says what's happening with the challenge's pods.