change the modifiers to private from public and lift return out of 'if'#1088
Merged
neetopia merged 3 commits intogoogle:mainfrom Sep 9, 2022
Merged
change the modifiers to private from public and lift return out of 'if'#1088neetopia merged 3 commits intogoogle:mainfrom
neetopia merged 3 commits intogoogle:mainfrom
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Contributor
Author
|
Can anyone please review it? |
Contributor
|
I think the change for combining return statement and private val make sense to me, but I don't get the benefit of adding explicit types to the rest of your change, if no specific reasons, maybe let's not touch them. |
Contributor
Author
|
@neetopia I removed the added explicit type. |
Contributor
|
Thanks for your PR! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi i am Heli who using ksp.
First, changed some codes to not use the platform type. platform type requires unnecessary boilerplate(!!, let trick, ...) And open source is a guide to writing code.so i think bad code examples should be deleted.Second, Lift return out of 'if'
Third, change the modifiers to private from public
thanks. 🙇
--
There is no change that users can feel.