Fix ClassNotFoundException in case there are no SymbolProcessorProviders. #2718
+7
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ers.
Improved the error message.
Removed an unnecessary dependency `compileOnly(project(":kotlin-analysis-api"))`.
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Author
|
I've signed CLA, please rerun the workflow. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case when there are no any SymbolProcessorProvider implementations in the ksp classpath, I catch an exception.
java.lang.ClassNotFoundException: com.google.devtools.ksp.impl.KotlinSymbolProcessing$ExitCodeThere are no reasons to use this class to build an error message. So I fixed it, replaced with the class
com.google.devtools.ksp.processing.ExitCode.Also, I improved the error message to clarify what to do in case there a no symbol processor providers. And removed an unnecessary dependency
compileOnly(project(":kotlin-analysis-api")). It is unnecessary anymore.