Skip to content

Conversation

@jwillker
Copy link
Contributor

The version command was missing, as mentioned in this issue.

The goreleaser already setting build information here:

ldflags:
# prettier-ignore
- '-s -w -X main.version={{.Version}} -X main.commit={{.Commit}} -X main.date={{.CommitDate}}'
, to take advantage of this I implemented this feature based on this information.

The "urfave/cli" already has a clean way to implement this feature, as mentioned here: https://cli.urfave.org/v2/examples/version-flag/

@wolf99
Copy link
Contributor

wolf99 commented Dec 14, 2022

Relates to #18

@oliverchang
Copy link
Collaborator

Thank you so much for contributing this!

@another-rex
Copy link
Collaborator

/gcbrun

Copy link
Collaborator

@another-rex another-rex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!, Just two minor comments.

@another-rex
Copy link
Collaborator

/gcbrun

@another-rex another-rex merged commit 23ec6e1 into google:main Dec 15, 2022
julieqiu pushed a commit to julieqiu/osv-scanner that referenced this pull request May 2, 2023
julieqiu pushed a commit to julieqiu/osv-scanner that referenced this pull request May 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants