Skip to content

Adding custom env, terminationGracePeriodSeconds, priorityClassName #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 6, 2025
Merged

Adding custom env, terminationGracePeriodSeconds, priorityClassName #13

merged 1 commit into from
Apr 6, 2025

Conversation

@RoshaniN
Copy link
Collaborator

@RoshaniN RoshaniN commented Apr 5, 2025 •
edited
Loading

  1. Custom env support added
  2. ChipsPerVM = 8 for -8t machine types, used for worker resources in "google.com/tpu":
  3. priorityClassName for workerSpec - anything other than default priority can be specified (with XPK Kueue)
  4. terminationGracePeriodSeconds to support suspend/ resume
  5. Adding resource limits for RM and proxy

@RoshaniN RoshaniN force-pushed the custom_env branch 2 times, most recently from e5b975f to 34ba97f Compare April 5, 2025 01:43
@RoshaniN RoshaniN mentioned this pull request Apr 5, 2025
Merged
shauryagup
shauryagup approved these changes Apr 5, 2025
View reviewed changes
Copy link
Collaborator

@shauryagup shauryagup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Just a few minor comments and one question

@RoshaniN
Copy link
Collaborator Author

RoshaniN commented Apr 5, 2025 •
edited
Loading

PATHWAYS_HEAD is not getting injected as expected, it remains empty in resource_manager_address. I will merge the PR after this is resolved.
Edit: Solved.

shauryagup
shauryagup reviewed Apr 5, 2025
View reviewed changes
@RoshaniN RoshaniN merged commit 827a12e into main Apr 6, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shauryagup shauryagup shauryagup approved these changes

@SujeethJinesh SujeethJinesh SujeethJinesh approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@RoshaniN @shauryagup @SujeethJinesh