Skip to content

Pass capacity node selector to JobSet #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 2, 2025
Merged

Pass capacity node selector to JobSet #35

merged 1 commit into from
Oct 2, 2025

Conversation

@wstcliyu
Copy link
Collaborator

@wstcliyu wstcliyu commented Sep 30, 2025

Context: b/440622266

We need to plumb the reservation name so that a Pathways workload can also specify the capacity.

@wstcliyu wstcliyu requested a review from RoshaniN as a code owner September 30, 2025 18:26
lukebaumann
lukebaumann reviewed Sep 30, 2025
View reviewed changes
lukebaumann
lukebaumann requested changes Sep 30, 2025
View reviewed changes
Copy link
Member

@lukebaumann lukebaumann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Left one comment.

@wstcliyu wstcliyu force-pushed the wstcliyu/capacity-node-selector branch from 2c41749 to 7683ca8 Compare September 30, 2025 23:11
lukebaumann
lukebaumann approved these changes Oct 1, 2025
View reviewed changes
Copy link
Member

@lukebaumann lukebaumann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

shauryagup
shauryagup reviewed Oct 1, 2025
View reviewed changes
Copy link
Collaborator

@shauryagup shauryagup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI - We also need a PR on XPK to use the new field

@wstcliyu wstcliyu force-pushed the wstcliyu/capacity-node-selector branch 2 times, most recently from a40299f to cc94d43 Compare October 1, 2025 22:39
@wstcliyu
Copy link
Collaborator Author

wstcliyu commented Oct 1, 2025

FYI - We also need a PR on XPK to use the new field

Yes and it's already merged.
AI-Hypercomputer/xpk#664

@wstcliyu wstcliyu force-pushed the wstcliyu/capacity-node-selector branch from affb1ee to 057c0ac Compare October 2, 2025 00:02
@wstcliyu wstcliyu requested review from lukebaumann and removed request for RoshaniN, guptaaka and lukebaumann October 2, 2025 00:02
@lukebaumann lukebaumann merged commit ce98fe9 into main Oct 2, 2025
1 check passed
@wstcliyu wstcliyu mentioned this pull request Oct 3, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lukebaumann lukebaumann lukebaumann approved these changes

@shauryagup shauryagup shauryagup approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@wstcliyu @lukebaumann @shauryagup