This CL, while addressing a crash in _fast_dot_general when using per-element scales (tile_size=1) on contracting axes, fundamentally changed the behavior of the core utility qarray.get_tiled_axes. Previously, get_tiled_axes was understood to report only subchannel tiling (tile_size > 1). The change to include per-element scaled axes (tile_size=1) for all axis types, including contracting ones, introduces complexity and potential unintended side effects across the Qwix codebase, as other modules might implicitly rely on the old behavior.#253
Merged
Conversation
…-element scales (tile_size=1) on contracting axes, fundamentally changed the behavior of the core utility qarray.get_tiled_axes. Previously, get_tiled_axes was understood to report only subchannel tiling (tile_size > 1). The change to include per-element scaled axes (tile_size=1) for all axis types, including contracting ones, introduces complexity and potential unintended side effects across the Qwix codebase, as other modules might implicitly rely on the old behavior. PiperOrigin-RevId: 899264546
82c2e89 to
0ba773a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This CL, while addressing a crash in _fast_dot_general when using per-element scales (tile_size=1) on contracting axes, fundamentally changed the behavior of the core utility qarray.get_tiled_axes. Previously, get_tiled_axes was understood to report only subchannel tiling (tile_size > 1). The change to include per-element scaled axes (tile_size=1) for all axis types, including contracting ones, introduces complexity and potential unintended side effects across the Qwix codebase, as other modules might implicitly rely on the old behavior.