Skip to content

1.3.x regression: build-time test failure on 32-bit architectures #266

Description

@smcv

Since Debian updated libsnappy from 1.2.2 to 1.3.1, build-time tests are failing on i386 (32-bit x86) and armhf (32-bit ARM):

[ RUN      ] Snappy.LiteralLengthU32Overflow
./snappy_unittest.cc:1011: Failure
Value of: snappy::Uncompress(compressed.data(), compressed.size(), &uncompressed)
  Actual: true
Expected: false

./snappy_unittest.cc:1013: Failure
Value of: snappy::IsValidCompressedBuffer(compressed.data(), compressed.size())
  Actual: true
Expected: false

[  FAILED  ] Snappy.LiteralLengthU32Overflow (0 ms)

I think this is because 7406111 is assuming that size_t is larger than 32 bits.

An i386 version of libsnappy is used by ffmpeg, and indirectly by 32-bit Wine, which is one of the remaining use-cases for i386 binaries on an otherwise 64-bit-capable machine.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions