Skip to content

Fix -Wsuggest-override warnings from Clang #175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
danilak-G merged 2 commits into from
Apr 4, 2024
Merged

Fix -Wsuggest-override warnings from Clang #175

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8774875
Fix -Wsuggest-override warnings from Clang
Quuxplusone Dec 29, 2023
41a3ade
Silence -Wdeprecated warning on clang
HowardHinnant Dec 18, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions snappy.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1695,16 +1695,16 @@ class SnappyIOVecReader : public Source {
if (total_size > 0 && curr_size_remaining_ == 0) Advance();
}

~SnappyIOVecReader() = default;
~SnappyIOVecReader() override = default;

size_t Available() const { return total_size_remaining_; }
size_t Available() const override { return total_size_remaining_; }

const char* Peek(size_t* len) {
const char* Peek(size_t* len) override {
*len = curr_size_remaining_;
return curr_pos_;
}

void Skip(size_t n) {
void Skip(size_t n) override {
while (n >= curr_size_remaining_ && n > 0) {
n -= curr_size_remaining_;
Advance();
Expand Down Expand Up @@ -2341,7 +2341,6 @@ bool SnappyScatteredWriter<Allocator>::SlowAppendFromSelf(size_t offset,
class SnappySinkAllocator {
public:
explicit SnappySinkAllocator(Sink* dest) : dest_(dest) {}
~SnappySinkAllocator() {}

char* Allocate(int size) {
Datablock block(new char[size], size);
Expand Down