sys/linux/vnet: added descriptions for ipv4 icmp extended headers #4045
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added descriptions for structures and constants for ipv4 icmp echo and reply extended headers.
a-nogikh
reviewed
Jul 19, 2023
| ident icmp_ext_echo_iio_ident | ||
| } [packed] | ||
|
|
||
| icmp_ext_echo_iio_ident { |
Collaborator
There was a problem hiding this comment.
Should it rather be a union? I.e. either name, or ipv4, or ipv6?
| id int16be | ||
| seq_num int16be | ||
| icmp_ext_hdr icmp_ext_hdr | ||
| iio icmp_ext_echo_iio |
Collaborator
There was a problem hiding this comment.
https://datatracker.ietf.org/doc/html/draft-bonica-intarea-eping-04#section-2
When applied to the ICMP Extended Echo Request message, the ICMP Extension Structure contains
one or two instances of the Interface Identification Object
| seq_num int16be | ||
| icmp_ext_hdr icmp_ext_hdr | ||
| iio icmp_ext_echo_iio | ||
| data array[int8] |
Collaborator
There was a problem hiding this comment.
Does the packet include any arbitrary payload beyond what's described above?
The question is related to both request and reply structures.
| id int16be | ||
| seq_num int16be | ||
| icmp_ext_hdr icmp_ext_hdr | ||
| iio icmp_ext_echo_iio |
Collaborator
There was a problem hiding this comment.
Does the reply contain iio?
https://datatracker.ietf.org/doc/html/draft-bonica-intarea-eping-04#section-3
Collaborator
|
Please also address this CI error: It's about your first commit's description. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The extended headers are for echo and reply echo messages.