Skip to content

KCIDB REST migration, schema upgrade, and tooling updates #6397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
a-nogikh merged 3 commits into from
Oct 6, 2025
Merged

KCIDB REST migration, schema upgrade, and tooling updates #6397

a-nogikh merged 3 commits into from
Oct 6, 2025

Conversation

@nuclearcat
Copy link
Contributor

@nuclearcat nuclearcat commented Oct 2, 2025 •
edited
Loading

  1. Upgrade the KCIDB submission schema to v5.3 and align the converter with the new checkout/build/test layout.
  2. Replace the Google Pub/Sub publisher with direct REST submissions driven by configurable endpoint and bearer token settings.
  3. Extend syz-kcidb tooling with REST credentials plus -input/-output helpers for easier, local KCIDB payload testing.

Note: Dashboard configs now require kcidb.resturi and kcidb.token; the old project, topic, and credentials fields are removed.

@a-nogikh a-nogikh self-requested a review October 2, 2025 09:08
@a-nogikh
Copy link
Collaborator

a-nogikh commented Oct 2, 2025

Thanks!
Please note the CI errors:

pkg/kcidb/schema.go:135:1: The line is 125 characters long, which exceeds the maximum of 120 characters. (lll)
Error: The line is 125 characters long, which exceeds the maximum of 120 characters. (lll)
pkg/kcidb/schema.go:144:1: The line is 144 characters long, which exceeds the maximum of 120 characters. (lll)
Error: The line is 144 characters long, which exceeds the maximum of 120 characters. (lll)
dashboard/app/config.go:817:2: lint: Standalone comments should be complete sentences with first word capitalized and a period at the end (syz-linter)
Error: lint: Standalone comments should be complete sentences with first word capitalized and a period at the end (syz-linter)
pkg/kcidb/client.go:33:37: lint: Use 'origin, resturi, token string' (syz-linter)
Error: lint: Use 'origin, resturi, token string' (syz-linter)
tools/syz-kcidb/kcidb.go:66:2: lint: Add a period at the end of the comment (syz-linter)
Error: lint: Add a period at the end of the comment (syz-linter)
5 issues:
* lll: 2
* syz-linter: 3
Error: Process completed with exit code 2.

Error: Wrong commit subject format: 'kcidb: Convert from Google PubSub to plain REST interface'. Please use 'main/affected/package: short change description'. See docs/contributing.md for details. Regex pattern used to check commit subjects is '^(Revert "|(([a-z0-9/_.-]+|Makefile|CONTRIBUTORS|README.md)(, )?)+:\ [^A-Z].+[^.]$)'.
Error: Wrong commit subject format: 'pkg/kcidb: Upgrade submission schema to v5.3'. Please use 'main/affected/package: short change description'. See docs/contributing.md for details. Regex pattern used to check commit subjects is '^(Revert "|(([a-z0-9/_.-]+|Makefile|CONTRIBUTORS|README.md)(, )?)+:\ [^A-Z].+[^.]$)'.

a-nogikh
a-nogikh previously approved these changes Oct 2, 2025
View reviewed changes
Copy link
Collaborator

@a-nogikh a-nogikh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Please address the linter errors, then we will be able to merge the PR.

@nuclearcat
pkg/kcidb: upgrade submission schema to v5.3
a82bb62 
Upgrading KCIDB schema, as old versions going to be deprecated soon.
Ref: https://github.com/kernelci/kcidb-io/tree/main/kcidb_io/schema

Signed-off-by: Denys Fedoryshchenko <denys.f@collabora.com>
@nuclearcat nuclearcat marked this pull request as draft October 2, 2025 14:27
@nuclearcat
kcidb: convert from Google PubSub to plain REST interface
908f184 
KCIDB removing Google PubSub and start to accept REST submissions.
This will require new configuration options, such as REST URL and
 token.

Signed-off-by: Denys Fedoryshchenko <denys.f@collabora.com>
@nuclearcat
tools/syz-kcidb: add -input and -output flags for testing
2a6ecab 
Add -input and -output flags to syz-kcidb to allow for faster and
easier testing of KCIDB submissions.

With these flags, it's possible to use a local JSON file as input
for a bug report and to save the resulting KCIDB submission locally.
This removes the need for communication with the dashboard and KCIDB,
which simplifies testing and development.

Signed-off-by: Denys Fedoryshchenko <denys.f@collabora.com>
@nuclearcat nuclearcat marked this pull request as ready for review October 2, 2025 14:38
@nuclearcat nuclearcat requested a review from a-nogikh October 3, 2025 12:03
a-nogikh
a-nogikh approved these changes Oct 3, 2025
View reviewed changes
Copy link
Collaborator

@a-nogikh a-nogikh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!
I'll merge and deploy it on Monday

@a-nogikh a-nogikh added this pull request to the merge queue Oct 6, 2025
Merged via the queue into google:master with commit 91305db Oct 6, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@a-nogikh a-nogikh a-nogikh approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@nuclearcat @a-nogikh