Skip to content

Conversation

@Mrxsnj
Copy link

@Mrxsnj Mrxsnj commented Apr 7, 2021

'make kvmconfig' will be removed after Linux 5.10,
Please use 'make kvm_guest.config' instead.

'make kvmconfig' will be removed after Linux 5.10,
Please use 'make kvm_guest.config' instead.
@google-cla
Copy link

google-cla bot commented Apr 7, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@codecov
Copy link

codecov bot commented Apr 7, 2021

Codecov Report

Merging #2530 (1d9dbff) into master (6a81331) will not change coverage.
The diff coverage is n/a.

# After Linux kernel v5.10
make CC="$GCC/bin/gcc" defconfig
make CC="$GCC/bin/gcc" kvm_guest.config
```
Copy link
Contributor

@xairy xairy Apr 7, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would do:

cd $KERNEL
make CC="$GCC/bin/gcc" defconfig
# Before Linux kernel v5.10:
make CC="$GCC/bin/gcc" kvmconfig
# After Linux kernel v5.10:
make CC="$GCC/bin/gcc" kvm_guest.config

This way there's less duplication, and it's clearer to which lines the comments relate.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Absolutely, thx :)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we can do just kvm_guest.config? It's pretty old, I see it referenced at least in (so probably older):

commit de4619937229378e81f95e99c9866acc8e207d34
Date:   Fri Mar 13 15:21:38 2015 +0900
    kbuild: mergeconfig: fix "jobserver unavailable" warning
``

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I can't check commit de4619937229378e81f95e99c9866acc8e207d34.
I think it works in most cases:

I would do:

cd $KERNEL
make CC="$GCC/bin/gcc" defconfig
# Before Linux kernel v5.10:
make CC="$GCC/bin/gcc" kvmconfig
# After Linux kernel v5.10:
make CC="$GCC/bin/gcc" kvm_guest.config

This way there's less duplication, and it's clearer to which lines the comments relate.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can git checkout v5.0 && make kvm_guest.config, git checkout v4.14 && make kvm_guest.config, etc to find the oldest release that supports it.

@Mrxsnj
Copy link
Author

Mrxsnj commented May 10, 2021

@googlebot I signed it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants