Skip to content

Talent: Deprecate job visibility (via synth). #9050

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 19, 2019
Merged

Talent: Deprecate job visibility (via synth). #9050

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion talent/google/cloud/talent_v4beta1/gapic/enums.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -445,6 +445,8 @@ class SkillProficiencyLevel(enum.IntEnum):

class Visibility(enum.IntEnum):
"""
Deprecated. All resources are only visible to the owner.

An enum that represents who has view access to the resource.

Attributes:
Expand Down Expand Up @@ -869,7 +871,7 @@ class LocationType(enum.IntEnum):
class LocationFilter(object):
class TelecommutePreference(enum.IntEnum):
"""
Specify whether including telecommute jobs.
Specify whether to include telecommute jobs.

Attributes:
TELECOMMUTE_PREFERENCE_UNSPECIFIED (int): Default value if the telecommute preference isn't specified.
Expand Down
4 changes: 2 additions & 2 deletions talent/google/cloud/talent_v4beta1/gapic/profile_service_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -790,9 +790,9 @@ def search_profiles(

- "relevance desc": By descending relevance, as determined by the API
algorithms.
- "update\_time desc": Sort by ``Profile.update_time`` in descending
- "update\_date desc": Sort by ``Profile.update_time`` in descending
order (recently updated profiles first).
- "create\_time desc": Sort by ``Profile.create_time`` in descending
- "create\_date desc": Sort by ``Profile.create_time`` in descending
order (recently created profiles first).
- "first\_name": Sort by ``PersonName.PersonStructuredName.given_name``
in ascending order.
Expand Down
4 changes: 4 additions & 0 deletions talent/google/cloud/talent_v4beta1/proto/common.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -442,8 +442,12 @@ enum PostingRegion {
TELECOMMUTE = 3;
}

// Deprecated. All resources are only visible to the owner.
//
// An enum that represents who has view access to the resource.
enum Visibility {
option deprecated = true;

// Default value.
VISIBILITY_UNSPECIFIED = 0;

Expand Down
27 changes: 14 additions & 13 deletions talent/google/cloud/talent_v4beta1/proto/common_pb2.py
View file
Open in desktop

Large diffs are not rendered by default.

50 changes: 44 additions & 6 deletions talent/google/cloud/talent_v4beta1/proto/filters.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -222,7 +222,43 @@ message ProfileQuery {
// [LocationFilter.negated][google.cloud.talent.v4beta1.LocationFilter.negated]
// is specified, the result doesn't contain profiles from that location.
//
// For example, search for profiles with addresses in "New York City".
// If
// [LocationFilter.address][google.cloud.talent.v4beta1.LocationFilter.address]
// is provided, the
// [LocationType][google.cloud.talent.v4beta1.Location.LocationType], center
// point (latitude and longitude), and radius are automatically detected by
// the Google Maps Geocoding API and included as well. If
// [LocationFilter.address][google.cloud.talent.v4beta1.LocationFilter.address]
// is not recognized as a location, the filter falls back to keyword search.
//
// If the detected
// [LocationType][google.cloud.talent.v4beta1.Location.LocationType] is
// [LocationType.SUB_ADMINISTRATIVE_AREA][google.cloud.talent.v4beta1.Location.LocationType.SUB_ADMINISTRATIVE_AREA],
// [LocationType.ADMINISTRATIVE_AREA][google.cloud.talent.v4beta1.Location.LocationType.ADMINISTRATIVE_AREA],
// or
// [LocationType.COUNTRY][google.cloud.talent.v4beta1.Location.LocationType.COUNTRY],
// or location is recognized but a radius can not be determined by the
// geo-coder, the filter is performed against the detected location name
// (using exact text matching). Otherwise, the filter is performed against the
// detected center point and a radius. The largest value from among the
// following options is automatically set as the radius value:
// 1. 10 miles.
// 2. Detected location radius +
// [LocationFilter.distance_in_miles][google.cloud.talent.v4beta1.LocationFilter.distance_in_miles].
// 3. If the detected
// [LocationType][google.cloud.talent.v4beta1.Location.LocationType] is one of
// [LocationType.SUB_LOCALITY][google.cloud.talent.v4beta1.Location.LocationType.SUB_LOCALITY],
// [LocationType.SUB_LOCALITY_2][google.cloud.talent.v4beta1.Location.LocationType.SUB_LOCALITY_2],
// [LocationType.NEIGHBORHOOD][google.cloud.talent.v4beta1.Location.LocationType.NEIGHBORHOOD],
// [LocationType.POSTAL_CODE][google.cloud.talent.v4beta1.Location.LocationType.POSTAL_CODE],
// or
// [LocationType.STREET_ADDRESS][google.cloud.talent.v4beta1.Location.LocationType.STREET_ADDRESS],
// the following two values are calculated and the larger of the two is
// compared to #1 and #2, above:
// - Calculated radius of the city (from the city center) that contains the
// geo-coded location.
// - Distance from the city center (of the city containing the geo-coded
// location) to the detected location center + 0.5 miles.
repeated LocationFilter location_filters = 2;

// Optional. Job title filter specifies job titles of profiles to match on.
Expand Down Expand Up @@ -376,7 +412,7 @@ message ProfileQuery {
//
// Geographic region of the search.
message LocationFilter {
// Specify whether including telecommute jobs.
// Specify whether to include telecommute jobs.
enum TelecommutePreference {
// Default value if the telecommute preference isn't specified.
TELECOMMUTE_PREFERENCE_UNSPECIFIED = 0;
Expand Down Expand Up @@ -405,13 +441,13 @@ message LocationFilter {
// Note that this filter is not applicable for Profile Search related queries.
string region_code = 2;

// Optional. The latitude and longitude of the geographic center from which to
// search. This field's ignored if `address` is provided.
// Optional. The latitude and longitude of the geographic center to search
// from. This field is ignored if `address` is provided.
google.type.LatLng lat_lng = 3;

// Optional. The distance_in_miles is applied when the location being searched
// for is identified as a city or smaller. When the location being searched
// for is a state or larger, this field is ignored.
// for is identified as a city or smaller. This field is ignored if the
// location being searched for is a state or larger.
double distance_in_miles = 4;

// Optional. Allows the client to return jobs without a
Expand All @@ -433,6 +469,8 @@ message LocationFilter {
// such as "Mountain View" or "telecommuting" jobs. However, when used in
// combination with other location filters, telecommuting jobs can be
// treated as less relevant than other jobs in the search response.
//
// This field is only used for job search requests.
TelecommutePreference telecommute_preference = 5;

// Optional. Whether to apply negation to the filter so profiles matching the
Expand Down
50 changes: 43 additions & 7 deletions talent/google/cloud/talent_v4beta1/proto/filters_pb2.py
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 4 additions & 2 deletions talent/google/cloud/talent_v4beta1/proto/job.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -285,12 +285,14 @@ message Job {
// the same location level as this field is strongly recommended.
PostingRegion posting_region = 20;

// Optional. The visibility of the job.
// Deprecated. The job is only visible to the owner.
//
// The visibility of the job.
//
// Defaults to
// [Visibility.ACCOUNT_ONLY][google.cloud.talent.v4beta1.Visibility.ACCOUNT_ONLY]
// if not specified.
Visibility visibility = 21;
Visibility visibility = 21 [deprecated = true];

// Optional. The start timestamp of the job in UTC time zone. Typically this
// field is used for contracting engagements. Invalid timestamps are ignored.
Expand Down
Loading