Skip to content

test(fix): set namespace for entity #1107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 14, 2023
Merged

test(fix): set namespace for entity #1107

merged 1 commit into from
Jun 14, 2023

Conversation

@kolea2
Copy link
Contributor

@kolea2 kolea2 commented Jun 9, 2023

Because we were calling setKey, the namespace was getting overwritten to [default] and not getting cleaned up after tests were run as a result.

@kolea2 kolea2 requested review from a team as code owners June 9, 2023 15:27
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: datastore Issues related to the googleapis/java-datastore API. labels Jun 9, 2023
@kolea2 kolea2 added the owlbot:run Add this label to trigger the Owlbot post processor. label Jun 9, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jun 9, 2023
@kolea2 kolea2 merged commit b1227dd into googleapis:main Jun 14, 2023
@kolea2 kolea2 deleted the testing-it branch June 14, 2023 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@jainsahab jainsahab jainsahab approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: datastore Issues related to the googleapis/java-datastore API. size: xs Pull request size is extra small.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kolea2 @jainsahab