Skip to content

test: add DatastoreException assertions in integration tests #1396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 18, 2024
Merged

test: add DatastoreException assertions in integration tests #1396

merged 4 commits into from
Apr 18, 2024

Conversation

@kolea2
Copy link
Contributor

@kolea2 kolea2 commented Apr 4, 2024

No description provided.

@kolea2 kolea2 requested review from a team as code owners April 4, 2024 19:06
@product-auto-label product-auto-label bot added size: s Pull request size is small. api: datastore Issues related to the googleapis/java-datastore API. labels Apr 4, 2024
@kolea2 kolea2 added the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 4, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 4, 2024
@kolea2 kolea2 requested a review from a team as a code owner April 4, 2024 19:49
@kolea2 kolea2 added the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 17, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 17, 2024
danieljbruce
danieljbruce reviewed Apr 17, 2024
View reviewed changes
Copy link

@danieljbruce danieljbruce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just curious about one thing here.

@kolea2 kolea2 added the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 17, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 17, 2024
@kolea2
Copy link
Contributor Author

kolea2 commented Apr 17, 2024

/gcbrun

1 similar comment
@kolea2
Copy link
Contributor Author

kolea2 commented Apr 18, 2024

/gcbrun

@kolea2 kolea2 merged commit 9ef89ba into googleapis:main Apr 18, 2024
@kolea2 kolea2 deleted the exception-testing branch April 18, 2024 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@danieljbruce danieljbruce danieljbruce approved these changes

+1 more reviewer

@cindy-peng cindy-peng cindy-peng approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: datastore Issues related to the googleapis/java-datastore API. size: s Pull request size is small.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kolea2 @danieljbruce @cindy-peng