Skip to content

chore!: remove deprecated getCollections() methods #307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 22, 2020
Merged

chore!: remove deprecated getCollections() methods #307

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 7 additions & 13 deletions google-cloud-firestore/clirr-ignored-differences.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,23 +17,17 @@

<!-- see http://www.mojohaus.org/clirr-maven-plugin/examples/ignored-differences.html -->
<differences>
<!-- TODO: Remove after release of 1.33.0 -->
<difference>
<differenceType>7012</differenceType>
<className>com/google/cloud/firestore/Firestore</className>
<method>com.google.api.core.ApiFuture runAsyncTransaction(*)</method>
</difference>

<!-- v2.0.0 -->
<difference>
<differenceType>7005</differenceType>
<className>com/google/cloud/firestore/*</className>
<method>*(com.google.cloud.firestore.FirestoreImpl, *)</method>
<to>*(com.google.cloud.firestore.FirestoreRpcContext, *)</to>
<differenceType>7002</differenceType>
<className>com/google/cloud/firestore/DocumentReference</className>
<method>java.lang.Iterable getCollections()</method>
</difference>
<difference>
<differenceType>7009</differenceType>
<className>com/google/cloud/firestore/*</className>
<method>*(com.google.cloud.firestore.FirestoreImpl, *)</method>
<differenceType>7002</differenceType>
<className>com/google/cloud/firestore/Firestore</className>
<method>java.lang.Iterable getCollections()</method>
</difference>

<!--
Expand Down
13 changes: 0 additions & 13 deletions google-cloud-firestore/src/main/java/com/google/cloud/firestore/DocumentReference.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -416,19 +416,6 @@ public void remove() {
};
}

/**
* Fetches the subcollections that are direct children of this document.
*
* @deprecated Use {@link #listCollections()}.
* @throws FirestoreException if the Iterable could not be initialized.
* @return An Iterable that can be used to fetch all subcollections.
*/
@Deprecated
@Nonnull
public Iterable<CollectionReference> getCollections() {
return listCollections();
}

/**
* Starts listening to the document referenced by this DocumentReference.
*
Expand Down
11 changes: 0 additions & 11 deletions google-cloud-firestore/src/main/java/com/google/cloud/firestore/Firestore.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,17 +55,6 @@ public interface Firestore extends Service<FirestoreOptions>, AutoCloseable {
@Nonnull
Iterable<CollectionReference> listCollections();

/**
* Fetches the root collections that are associated with this Firestore database.
*
* @deprecated Use {@link #listCollections()}.
* @throws FirestoreException if the Iterable could not be initialized.
* @return An Iterable that can be used to fetch all collections.
*/
@Deprecated
@Nonnull
Iterable<CollectionReference> getCollections();

/**
* Creates and returns a new @link{Query} that includes all documents in the database that are
* contained in a collection or subcollection with the given @code{collectionId}.
Expand Down
6 changes: 0 additions & 6 deletions google-cloud-firestore/src/main/java/com/google/cloud/firestore/FirestoreImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,12 +120,6 @@ public Iterable<CollectionReference> listCollections() {
return rootDocument.listCollections();
}

@Nonnull
@Override
public Iterable<CollectionReference> getCollections() {
return listCollections();
}

@Nonnull
@Override
public ApiFuture<List<DocumentSnapshot>> getAll(
Expand Down