Skip to content

fix(sidekick/swift): empty LRO responses should return Void on wait()#6260

Merged
chingor13 merged 2 commits into
mainfrom
empty-lro
Jun 2, 2026
Merged

fix(sidekick/swift): empty LRO responses should return Void on wait()#6260
chingor13 merged 2 commits into
mainfrom
empty-lro

Conversation

@chingor13

Copy link
Copy Markdown
Contributor

Fixes #6256

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds support for Long-Running Operations (LRO) with empty responses in Swift code generation by mapping .google.protobuf.Empty to Void and updating the Swift service template. Feedback is provided to correct the test diff output format to comply with the local Go style guide.

Comment thread internal/sidekick/swift/annotate_method_test.go
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Signed-off-by: Jeff Ching <chingor@google.com>
@chingor13 chingor13 marked this pull request as ready for review June 2, 2026 15:14
@chingor13 chingor13 requested a review from a team as a code owner June 2, 2026 15:14
@chingor13 chingor13 merged commit 73c9e5a into main Jun 2, 2026
51 of 52 checks passed
@chingor13 chingor13 deleted the empty-lro branch June 2, 2026 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

sidekick: swift LROs should Void if the response type is google.protobuf.Empty

2 participants