feat(sidekick/swift): support discovery-based modules#6351
Merged
coryan merged 2 commits intoJun 9, 2026
Conversation
We need to write Swift tests for the discovery-based generated code. In particular, serialization and deserialization of bytes. This is easier to test if we control the discovery doc, and that recommends using a module.
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the Swift module generation to support configurable specification formats (such as Discovery) instead of defaulting exclusively to Protobuf. It also refactors the corresponding unit tests to validate the entire ModelConfig struct and adds a test case for the discovery format. The reviewer suggested updating the discovery test case to expect 'discovery' as the active root in SourceConfig to align with the defaulting behavior.
noahdietz
approved these changes
Jun 9, 2026
jskeet
pushed a commit
that referenced
this pull request
Jun 10, 2026
🤖 I have created a release *beep* *boop* --- ## [0.20.0](v0.19.0...v0.20.0) (2026-06-10) ### Features * **nodejs:** add a DefaultVersion field to NodeJSPackage ([#6358](#6358)) ([af3218f](af3218f)) * **sidekick/rust:** add bigquery code gen ([#6322](#6322)) ([a7846f5](a7846f5)) * **sidekick/swift:** non-string maps ([#6361](#6361)) ([2b6d7e4](2b6d7e4)) * **sidekick/swift:** support discovery-based modules ([#6351](#6351)) ([09ef5cf](09ef5cf)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We need to write Swift tests for the discovery-based generated code. In particular, serialization and deserialization of bytes. This is easier to test if we control the discovery doc, and that recommends using a module.
Towards #5748