chore(filter): Add a switch statement #1108
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the filter function a switch statement is added so that it is clear to the reader what happens when the arguments are of various lengths
|
🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use -- conventional-commit-lint bot |
…ithub.com/danieljbruce/nodejs-datastore into 1096-filter-function-should-have-a-switch
vicb
reviewed
May 3, 2023
src/query.ts
Outdated
| case 1: { | ||
| if (isFilter(propertyOrFilter)) { | ||
| this.entityFilters.push(propertyOrFilter); | ||
| } else { |
There was a problem hiding this comment.
I think the else branch should be removed here (operatorOrValue and value are not provided)
vicb
reviewed
May 3, 2023
src/query.ts
Outdated
| case 2: { | ||
| this.filters.push({ | ||
| name: (propertyOrFilter as String).trim(), | ||
| op: '=' as Operator, |
There was a problem hiding this comment.
as Operator is probably not needed here?
Remove the else block, it should never happen anyway because if it does then the user is misusing the function
ruyadorno
approved these changes
May 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the filter function a switch statement is added so that it is clear to the reader what happens when the arguments are of various lengths.
Fixes #1096