fix: support sub-meanings for datastore v2.20.3 #1014
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gkevinzheng
approved these changes
Mar 21, 2025
|
It looks like this change also requires a backwards-compatibility fix on the datastore side. I opened googleapis/python-datastore#603 We can merge this after the datastore PR is merged and released. Marking as draft I also marked the problematic datastore version as not supported in setup.py |
|
googleapis/python-datastore#603 has been merged, so this is ready to go |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Datastore v2.20.2 made a change to how the meaning field for lists is recorded. Previously, the meaning field was saved for each element in the array, but the array itself wouldn't have a root meaning recorded. After v2.20.2, the meaning was stored as a tuple of
(root_meaning, sub_meaning_list)This PR fixed the ndb library's meaning parser to support both the new and old formats, and adds tests for both formats
Fixes #1006, #1005