chore: Restore code coverage #855
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rwhogg
commented
Dec 15, 2022
| def context(self): | ||
| return self._context.get() | ||
|
|
||
| except ImportError: # pragma: NO PY3 COVER |
There was a problem hiding this comment.
Note: it's easier to see that this change is correct if you view it with split-diffs and while ignoring whitespace changes
rwhogg
commented
Dec 15, 2022
| try: | ||
| a.frombytes(s) | ||
| except AttributeError: # pragma: NO PY3 COVER | ||
| a.fromstring(s) |
There was a problem hiding this comment.
fromstring is a deprecated alias for frombytes. Ditto for tostring vs. tobytes.
The string versions date from Py2 and were renamed and aliased in Py3 due to the bytes/string distinction. The aliases were removed in Python 3.9.
Mostly get rid of older Py2-only code
158ae76 to
ed4659b
Compare
parthea
approved these changes
Dec 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mostly get rid of older Py2-only code