Skip to content

fix: Remove usage of google.cloud.datastore.constants.DEFAULT_DATABASE #890

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 23, 2023
Merged

fix: Remove usage of google.cloud.datastore.constants.DEFAULT_DATABASE #890

merged 1 commit into from
Jun 23, 2023

Conversation

@rwhogg
Copy link
Contributor

@rwhogg rwhogg commented Jun 23, 2023

We did not end up creating that constant after all, so just use "" everywhere instead.

@rwhogg rwhogg requested review from a team as code owners June 23, 2023 14:41
@product-auto-label product-auto-label bot added the api: datastore Issues related to the googleapis/python-ndb API. label Jun 23, 2023
@rwhogg rwhogg force-pushed the multi-db-minimal-cleanup branch from a6f1308 to 095c50e Compare June 23, 2023 15:24
@rwhogg rwhogg merged commit a435576 into googleapis:multi-db Jun 23, 2023
@rwhogg rwhogg deleted the multi-db-minimal-cleanup branch June 23, 2023 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@m-strzelczyk m-strzelczyk m-strzelczyk approved these changes

Assignees

No one assigned

Labels

api: datastore Issues related to the googleapis/python-ndb API.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@rwhogg @m-strzelczyk