feat: add cloud.region, request_tag and transaction_tag in span attributes #1449
Conversation
b5ca757 to
af65849
Compare
f5bed57 to
1bd0a2c
Compare
15f395e to
6059b9b
Compare
| "enable_end_to_end_tracing", enable_end_to_end_tracing | ||
| ) | ||
| db_name = observability_options.get("db_name", db_name) | ||
| cloud_region = observability_options.get("cloud_region", cloud_region) |
There was a problem hiding this comment.
What is the use of this ?
IMU, observability_options is something which customers can set and does not have cloud_region property.
| db_name = observability_options.get("db_name", db_name) | ||
| cloud_region = observability_options.get("cloud_region", cloud_region) | ||
|
|
||
| cloud_region = _get_cloud_region() |
There was a problem hiding this comment.
This trace_call method is called for each and every span. Can we call this _get_cloud_region once and save the value as this should not change through the life of application
There was a problem hiding this comment.
Or handle this in _get_cloud_region method to make call to GoogleCloudResourceDetector only once.
| if "request_options" in attributes: | ||
| request_options = attributes.pop("request_options") | ||
| if request_options and request_options.request_tag: | ||
| attributes["spanner.request_tag"] = request_options.request_tag |
There was a problem hiding this comment.
Please use attribute name as request.tag and transaction.tag to be consistent with other languages.
There was a problem hiding this comment.
Do we also need the same for transaction.tag
| # Overwrite the requests timeout for the detector. | ||
| # This is necessary as the client will wait the full timeout if the | ||
| # code is not run in a GCP environment, with the location endpoints available. | ||
| gcp_resource_detector._TIMEOUT_SEC = 0.2 |
There was a problem hiding this comment.
Please check if we need this timeout in the new code after refactoring. Currently get region does not have any timeout
This change enhances observability by introducing these new features:
Cloud Region Attribute: The
cloud.regionattribute is now added to all OpenTelemetry spans generated by the Spanner client. This provides better geographical context for traces, aiding in performance analysis and debugging across different regions.Transaction Tag: The
transaction_tagset on aTransactionobject is now correctly propagated and included in theCommitrequest. This allows for better end-to-end traceability of transactions.Request Tag: This introduces support for
request_tagon individual Spanner operations likeread,execute_sql, andexecute_update. When arequest_tagis provided in therequest_options, it is now added as aspanner.request_tagattribute to the corresponding OpenTelemetry span. This allows for more granular tracing and debugging of specific requests within a transaction or a snapshot.