Skip to content

feat: add support for experimental host #1452

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

feat: add support for experimental host #1452

wants to merge 5 commits into from
+128 −13

Conversation

@sagnghos
Copy link

@sagnghos sagnghos commented Oct 29, 2025 •
edited
Loading

  • The changes make the python client compatible with experimental host over plain text communication.
  • The changes also ensure that the integration testing framework of python client is compatible with experimental host.

The support for tls and mTLS will be added via future PRs

@sagnghos sagnghos requested review from a team as code owners October 29, 2025 07:56
@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: spanner Issues related to the googleapis/python-spanner API. labels Oct 29, 2025
@rahul2393 rahul2393 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 29, 2025
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 29, 2025
@rahul2393 rahul2393 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 29, 2025
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 29, 2025
surbhigarg92
surbhigarg92 reviewed Oct 30, 2025
View reviewed changes
google/cloud/spanner_v1/database_sessions_manager.py
def __init__(self, database, pool, is_experimental_host: bool = False):
self._database = database
self._pool = pool
self._is_experimental_host = is_experimental_host
Copy link
Contributor

@surbhigarg92 surbhigarg92 Oct 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please keep the name consistent everywhere experimental_host or _experimental_host

@sagnghos sagnghos requested a review from surbhigarg92 October 30, 2025 10:20
@rahul2393 rahul2393 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 4, 2025
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@surbhigarg92 surbhigarg92 surbhigarg92 approved these changes

@rahul2393 rahul2393 rahul2393 approved these changes

Assignees

@surbhigarg92 surbhigarg92

Labels

api: spanner Issues related to the googleapis/python-spanner API. size: m Pull request size is medium.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@sagnghos @surbhigarg92 @rahul2393 @yoshi-kokoro