Repository navigation
core(icons): Add PNG check to icon validation - #6024
Merged
Merged
Conversation
brendankenny
suggested changes
Sep 14, 2018
brendankenny
left a comment
Contributor
There was a problem hiding this comment.
Nice! Love the new tests.
Just one big question (type?) and then some naming suggestions
brendankenny
suggested changes
Sep 17, 2018
brendankenny
left a comment
Contributor
There was a problem hiding this comment.
This all looks good. Last request for a case we didn't think about before :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #4876
Summary
Adds the additional check of validating if an icon is a PNG when validating that an icon is the correct size.
Notes
Changed the way that artifacts are computed in audit tests so that they can take in a manifest.json as a param to use multiple different manifests for testing.