feat: colab language client for an Colab server #287
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The language client maintains ownership of the `vscode-languageclient/node` `LanguageClient`, binding the correct middleware and `pipe`-ing the stream to be LSP compliant. Here we need to add `ws` and `@types/ws` to support the `WebSocket` communication. Minor update to `Updated src/test/helpers/uri.ts` ensuring we correctly parse URIs with port numbers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The language client maintains ownership of the
vscode-languageclient/nodeLanguageClient, binding the correct middleware andpipe-ing the stream to be LSP compliant.Here we need to add
wsand@types/wsto support theWebSocketcommunication.Minor update to
Updated src/test/helpers/uri.tsensuring we correctly parse URIs with port numbers.