Skip to content

fix regression: update thelper to v0.2.1#1639

Merged
ldez merged 4 commits into
golangci:masterfrom
ldez:feat/update-thelper
Jan 9, 2021
Merged

fix regression: update thelper to v0.2.1#1639
ldez merged 4 commits into
golangci:masterfrom
ldez:feat/update-thelper

Conversation

@ldez
Copy link
Copy Markdown
Member

@ldez ldez commented Jan 9, 2021

diff: kulti/thelper@v0.2.0...v0.2.1

With v0.2.0, all the sub-test functions are detected as a problem.

@ldez ldez added the bug Something isn't working label Jan 9, 2021
@ldez ldez requested a review from kulti January 9, 2021 02:16
Comment thread go.sum
Copy link
Copy Markdown
Contributor

@kulti kulti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread test/testdata/thelper.go Outdated
@ldez ldez dismissed SVilgelm’s stale review January 9, 2021 19:21

everything is fixed

@ldez ldez merged commit 44bf197 into golangci:master Jan 9, 2021
@ldez ldez deleted the feat/update-thelper branch January 9, 2021 19:21
ashanbrown pushed a commit to ashanbrown/golangci-lint that referenced this pull request Feb 20, 2021
@ldez ldez added this to the v1.35 milestone Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants