This repository was archived by the owner on Sep 9, 2020. It is now read-only.
gps: unset some GIT_* variables for git operations#1872
Merged
Conversation
This fixes 2 classes of bugs: - running unit tests as part of a git rebase invocation - running dep from a repository that has a separate GIT_DIR/GIT_WORK_TREE
Contributor
Author
|
note: #1868 is closely related |
sdboyer
approved these changes
Jul 2, 2018
Member
sdboyer
left a comment
There was a problem hiding this comment.
This is a great catch, it never occurred to me to excise these vars. Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this do / why do we need it?
This fixes 2 classes of bugs:
What should your reviewer look out for in this PR?
the location of the code might not be ideal.
Do you need help or clarification on anything?
Which issue(s) does this PR fix?
fixes #1871