Skip to content

x/mobile/bind: support slices of structs#101

Open
kevmo314 wants to merge 1 commit into
golang:masterfrom
kevmo314:master
Open

x/mobile/bind: support slices of structs#101
kevmo314 wants to merge 1 commit into
golang:masterfrom
kevmo314:master

Conversation

@kevmo314
Copy link
Copy Markdown

@kevmo314 kevmo314 commented May 5, 2024 •
edited
Loading

Adds code generation for supporting slices of structs in gobind.

Fixes golang/go#13445

NOTE: This PR isn't quite done yet, I'm having some trouble getting the testing environment set up. It seems like the default test environment is a bit outdated? In any case, could I use this PR's CI to iterate on test failures? Open to other suggestions as well.

@kevmo314
x/mobile/bind: support slices of structs
8ba93b9 
Adds code generation for supporting slices of structs in gobind.

Fixes golang/go#13445

NOTE: This PR isn't quite done yet, I'm having some trouble getting the testing environment set up. It seems like the default test environment is a bit outdated? In any case, could I use this PR's CI to iterate on test failures? Open to other suggestions as well.
@kevmo314 kevmo314 mentioned this pull request May 5, 2024
Open
@gopherbot
Copy link
Copy Markdown
Contributor

gopherbot commented May 5, 2024

This PR (HEAD: 8ba93b9) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/mobile/+/583196.

Important tips:

  • Don't comment on this PR. All discussion takes place in Gerrit.
  • You need a Gmail or other Google account to log in to Gerrit.
  • To change your code in response to feedback:
    • Push a new commit to the branch used by your GitHub PR.
    • A new "patch set" will then appear in Gerrit.
    • Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
    • Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
    • Multiple commits in the PR will be squashed by GerritBot.
  • The title and description of the GitHub PR are used to construct the final commit message.
    • Edit these as needed via the GitHub web interface (not via Gerrit or git).
    • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
  • See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

@gopherbot
Copy link
Copy Markdown
Contributor

gopherbot commented May 5, 2024

Message from Gopher Robot:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/583196.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Copy Markdown
Contributor

gopherbot commented May 5, 2024

Message from Gopher Robot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
A maintainer will review your change and provide feedback. See
https://go.dev/doc/contribute#review for more info and tips to get your
patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

Please don’t reply on this GitHub thread. Visit golang.org/cl/583196.
After addressing review feedback, remember to publish your drafts!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

x/mobile/bind: support slices of supported structs

2 participants

@kevmo314 @gopherbot