HOP canvas 렌더 순서 수정으로 rhwp 이미지 overlay 누락 방지#66
Merged
Conversation
Contributor
Author
|
|
Contributor
Author
|
|
Keep the PR 66 commits intact and add a focused HOP follow-up that preserves upstream overlay creation while replacing delayed full re-renders with flow-only re-renders. Split canvas layout and overlay lifecycle helpers out of CanvasView and tighten the validation baseline guard.
Owner
|
Maintainer follow-up commit을 이 PR 브랜치에 직접 얹었습니다. 기존 작성자 커밋 3개는 그대로 두고, 마지막에 추가 커밋에서는 upstream |
golbin
added a commit
that referenced
this pull request
May 27, 2026
Preserve contributor commits and include maintainer follow-up for flow-only delayed canvas re-render handling.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HOP의 canvas-view.ts에서 페이지 렌더링 시 canvas가 DOM에 붙기 전에 PageRenderer.renderPage()가 호출되던 문제를 수정했습니다. rhwp 0.7.11의 PageRenderer는 BehindText / InFrontOfText 이미지를 canvas 옆의 overlay sibling으로 생성하는데, 기존 HOP 구현은 렌더 시점에 canvas parent가 없어 overlay 생성이 누락될 수 있었습니다.
이로 인해 레이아웃이 이상하게 유지될때가 있었습니다.
수정 내용
-renderPage() 호출 전에 canvas를 먼저 #scroll-content에 append
-append 전에 applyCanvasDisplayLayout()으로 top, left, width, height를 먼저 세팅
-렌더 후 canvas 크기가 확정되면 layout을 다시 적용하고, 생성된 overlay에도 같은 위치/크기 적용
-페이지 release, 전체 release, reset 시 canvas뿐 아니라 해당 page overlay도 같이 제거
-resize/reposition 시 overlay도 canvas와 같이 이동하도록 처리
-canvas-view.test.ts에 렌더 호출 시점에 canvas parent와 left 값이 준비되어 있는지 검증 추가