Skip to content
This repository was archived by the owner on Oct 31, 2023. It is now read-only.

Conversation

@kmazurek
Copy link
Contributor

@kmazurek kmazurek commented Mar 22, 2019

Fixes: #3785

This changes the way output paths for tasks are handled. For each new task, a directory gets created in the output path from the task definition. The new directories' names are based on the task's name and their time of creation, e.g. some_task_2019-01-01_12-00-00.

@kmazurek kmazurek self-assigned this Mar 22, 2019
@ghost ghost added the in progress label Mar 22, 2019
@kmazurek kmazurek requested review from etam, jiivan and shadeofblue March 22, 2019 16:08
@etam
Copy link
Contributor

etam commented Mar 25, 2019

How this relates to #3854 ?

@kmazurek
Copy link
Contributor Author

@etam It fixes the same issue, but instead of focusing solely on the specific reported case (i.e. multi-frame tasks) this changes the way task output is handled in general.
Each task will get its own directory in the output path, with the directory names based on the task's name and creation timestamp (precision rounded up to seconds). This ensures there are no collisions between subsequent runs of the same task on one machine.

Copy link
Contributor

@jiivan jiivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

greencanoe

@codecov
Copy link

codecov bot commented Mar 25, 2019

Codecov Report

Merging #4037 into develop will increase coverage by 0.02%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop    #4037      +/-   ##
===========================================
+ Coverage    88.64%   88.66%   +0.02%     
===========================================
  Files          211      211              
  Lines        18402    18402              
===========================================
+ Hits         16312    16317       +5     
+ Misses        2090     2085       -5

Copy link
Contributor

@etam etam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this approach.

ok

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants