This repository was archived by the owner on Oct 31, 2023. It is now read-only.
New logic for setting up and cleaning up environments #4813
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EnvironmentManager now ensures that exactly one environment is active at a time. Once an environment is needed it is automatically prepared. It would be cleaned up when another environment is going to be used. This brings a disadvantage of keeping up idle environments but allows to avoid lengthy setups and cleanups if one environment is used a few times consecutively. Signed-off-by: Adam Wierzbicki <awierzbicki@golem.network>
maaktweluit
approved these changes
Oct 22, 2019
Contributor
maaktweluit
left a comment
There was a problem hiding this comment.
LGTM!
Small comment, still approving!
Codecov Report
@@ Coverage Diff @@
## mwu/e2e-rtm #4813 +/- ##
==============================================
Coverage ? 88.85%
==============================================
Files ? 229
Lines ? 21044
Branches ? 0
==============================================
Hits ? 18699
Misses ? 2345
Partials ? 0 |
mfranciszkiewicz
approved these changes
Oct 29, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EnvironmentManager now ensures that exactly one environment is active at a time. Once an environment is needed it is automatically prepared. It would be cleaned up when another environment is going to be used.
This brings a disadvantage of keeping up idle environments but allows to avoid lengthy setups and cleanups if one environment is used a few times consecutively.