Skip to content

yap: classfile v2#94

Merged
xushiwei merged 8 commits into
goplus:mainfrom
xushiwei:q
Mar 8, 2024
Merged

yap: classfile v2#94
xushiwei merged 8 commits into
goplus:mainfrom
xushiwei:q

Conversation

@xushiwei

@xushiwei xushiwei commented Mar 8, 2024

Copy link
Copy Markdown
Member

No description provided.

Comment thread classfile_v2.go
if me, ok := app.(interface{ MainEntry() }); ok {
me.MainEntry()
} else {
app.Run(":8080")

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[golangci-lint] Error return value of app.Run is not checked (errcheck)

Details

If you have any questions about this comment, feel free to raise an issue here:

@codecov

codecov Bot commented Mar 8, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.36%. Comparing base (1890aa1) to head (8474063).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #94   +/-   ##
=======================================
  Coverage   89.36%   89.36%           
=======================================
  Files          10       10           
  Lines          94       94           
=======================================
  Hits           84       84           
  Misses         10       10           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@@ -0,0 +1,3 @@
yap "article", {
"id": param("id"),
}

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[golangci-lint] invalid character U+0023 '#'

Details

If you have any questions about this comment, feel free to raise an issue here:

@@ -0,0 +1,3 @@
yap "article", {
"id": param("id"),
}

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[golangci-lint] syntax error: unexpected id in parameter list; possibly missing comma or ) (typecheck)

Details

If you have any questions about this comment, feel free to raise an issue here:

@@ -0,0 +1,3 @@
json {
"id": param("id"),
}

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[golangci-lint] invalid character U+0023 '#'

Details

If you have any questions about this comment, feel free to raise an issue here:

@@ -0,0 +1,3 @@
json {
"id": param("id"),
}

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[golangci-lint] syntax error: unexpected id in parameter list; possibly missing comma or ) (typecheck)

Details

If you have any questions about this comment, feel free to raise an issue here:

@xushiwei xushiwei merged commit f31eacf into goplus:main Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant