Skip to content

use gzip middleware #124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jmattheis merged 1 commit into from
Feb 9, 2019
Merged

use gzip middleware #124

jmattheis merged 1 commit into from
Feb 9, 2019

Conversation

@eternal-flame-AD
Copy link
Member

@eternal-flame-AD eternal-flame-AD commented Feb 5, 2019 •
edited
Loading

Currently, the built js bundle for WebUI is nearly 1 megabyte, which takes quite significant of time to transfer on a unstable network. With the plugin functionality the size nearly doubled (~1.8MB) due to the packed code editor and extra logos. Using gzip can significantly decrease the size transferred (60%+ bandwidth saved).
image

@codecov
Copy link

codecov bot commented Feb 5, 2019 •
edited
Loading

Codecov Report

Merging #124 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #124   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          39     39           
  Lines        1400   1400           
=====================================
  Hits         1400   1400
Impacted Files Coverage Δ
router/router.go 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 23442bf...f931034. Read the comment docs.

@jmattheis
Copy link
Member

jmattheis commented Feb 9, 2019

Could you update this pr, it now has merge conflicts after merging #110 .

@jmattheis jmattheis self-requested a review February 9, 2019 11:53
jmattheis
jmattheis previously approved these changes Feb 9, 2019
View reviewed changes
@eternal-flame-AD
Copy link
Member Author

eternal-flame-AD commented Feb 9, 2019

Okay, I have ran go mod tidy against the merge and the confliction should be resolved.

jmattheis
jmattheis reviewed Feb 9, 2019
View reviewed changes
@jmattheis
Copy link
Member

jmattheis commented Feb 9, 2019

@eternal-flame-AD I'm planning on adding a text chat for the Gotify project, which platform would you prefer? gitter, Slack, Discord or something else? (I'm asking you because I think you would probably use it) (I'd probably prefer Discord but I don't really care.)

@eternal-flame-AD
Copy link
Member Author

eternal-flame-AD commented Feb 9, 2019

I would prefer slack, I am a little more active on slack than Discord:), but Discord would be great too because a lot of project uses that.

@jmattheis jmattheis merged commit ccbe64a into gotify:master Feb 9, 2019
@jmattheis jmattheis added this to the v1.3.0 milestone Feb 9, 2019
@eternal-flame-AD eternal-flame-AD deleted the gzip branch February 11, 2019 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jmattheis jmattheis jmattheis approved these changes

Assignees

No one assigned

Labels

None yet

Milestone

v2.0.0

Development

Successfully merging this pull request may close these issues.

2 participants

@eternal-flame-AD @jmattheis