Mask secrets in command line logs#281
Conversation
This change introduces a `cmd.Mask` function that sanitizes leading environment variable assignments in command line strings by replacing their values with `[MASKED]`. The `runExec` helper in the `build` package is updated to use this function before logging commands, preventing accidental leakage of secrets in build logs. Unit tests are added to `cmd/cmd_test.go` and a regression test is added to `build/security_test.go`.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
As "Sentinel" 🛡️, I have identified a security risk where sensitive environment variables could be leaked in build logs. I have implemented a
cmd.Maskfunction and integrated it into the build pipeline's logging helper to ensure that secrets are masked.PR created automatically by Jules for task 841861877341282453 started by @pellared