Skip to content

Conversation

@jvandort
Copy link
Member

@jvandort jvandort commented Jun 19, 2025

Backport #33925 to 8.x

Fixes #33943

Reviewing cheatsheet

Before merging the PR, comments starting with

  • ❌ ❓must be fixed
  • 🤔 💅 should be fixed
  • 💭 may be fixed
  • 🎉 celebrate happy things

jvandort added 4 commits June 19, 2025 13:50
Sometimes a node's dependencies may be traversed with one set of transitive excludes.
Then, later in the graph traversal, a new edge may be connected to that original node with
less restrictive excludes. This changes the transitive excludes of the original node so that
it may bring in additional transitive dependenices.

We make sure to update the transitive excludes of a node's outgoing edges if it has already been
traversed so that those outgoing edges properly propagate their new excludes
Mark some nullable fields as nullable
Add comments where necessary
Adjust boolean logic to unconditionally run for loop, as its enclosing if statement will always be true
Remove logger that we don't really ever use
When we get an edge from the edge cache make sure to update its transitive exlcudes.
Since the edge is not attached at that point, also make sure to always recompute
a node's transitive excludes when an edge is added to it.

This can potentially open up optimizations in the future where we compute the node
exclusions eagerly when the edge is added to it, and only if the transitive excludes
change do we enqueue the node.
Add missing issue annotation to regression test
Fix test name
Fix javadoc wording
Update confusing/out-of-date comment
@jvandort jvandort changed the base branch from master to release8x June 19, 2025 18:06
@jvandort jvandort changed the title Jvandort/8x/backport 33925 Backport #33925 to 8.14.x Jun 19, 2025
@jvandort jvandort added this to the 8.14.3 milestone Jun 19, 2025
@jvandort jvandort self-assigned this Jun 19, 2025
@jvandort

This comment has been minimized.

@jvandort jvandort marked this pull request as ready for review June 19, 2025 18:18
@jvandort jvandort requested a review from a team as a code owner June 19, 2025 18:18
@jvandort jvandort requested a review from big-guy June 19, 2025 18:18
@bot-gradle

This comment has been minimized.

@jvandort jvandort requested a review from ljacomet June 19, 2025 18:18
@bot-gradle
Copy link
Collaborator

The following builds have failed:

@ljacomet
Copy link
Member

ljacomet commented Jul 3, 2025

@bot-gradle test this

@bot-gradle

This comment has been minimized.

@bot-gradle
Copy link
Collaborator

The following builds have passed:

@cobexer cobexer enabled auto-merge July 3, 2025 13:07
@cobexer cobexer linked an issue Jul 3, 2025 that may be closed by this pull request
@cobexer cobexer added this pull request to the merge queue Jul 3, 2025
Merged via the queue into release8x with commit 8986356 Jul 3, 2025
15 checks passed
@cobexer cobexer deleted the jvandort/8x/backport-33925 branch July 3, 2025 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Backport] Missing dependency even if all paths do not exclude it

5 participants