-
Notifications
You must be signed in to change notification settings - Fork 5k
Backport #33925 to 8.14.x #33951
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Backport #33925 to 8.14.x #33951
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sometimes a node's dependencies may be traversed with one set of transitive excludes. Then, later in the graph traversal, a new edge may be connected to that original node with less restrictive excludes. This changes the transitive excludes of the original node so that it may bring in additional transitive dependenices. We make sure to update the transitive excludes of a node's outgoing edges if it has already been traversed so that those outgoing edges properly propagate their new excludes
Mark some nullable fields as nullable Add comments where necessary Adjust boolean logic to unconditionally run for loop, as its enclosing if statement will always be true Remove logger that we don't really ever use
When we get an edge from the edge cache make sure to update its transitive exlcudes. Since the edge is not attached at that point, also make sure to always recompute a node's transitive excludes when an edge is added to it. This can potentially open up optimizations in the future where we compute the node exclusions eagerly when the edge is added to it, and only if the transitive excludes change do we enqueue the node.
Add missing issue annotation to regression test Fix test name Fix javadoc wording Update confusing/out-of-date comment
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
The following builds have failed: |
|
@bot-gradle test this |
This comment has been minimized.
This comment has been minimized.
|
The following builds have passed: |
ljacomet
approved these changes
Jul 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #33925 to 8.x
Fixes #33943
Reviewing cheatsheet
Before merging the PR, comments starting with