Reuse CC upon unrelated changes to gradle.properties
#34712
Draft
+147
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bot-gradle test ACC |
This comment has been minimized.
This comment has been minimized.
|
The following builds have passed: |
|
The following builds have failed: |
|
The following builds have failed: |
mlopatkin
reviewed
Aug 19, 2025
| outputContains "configuration cache cannot be reused because Gradle property 'foo' has changed." | ||
| } | ||
|
|
||
| def "invalidates cache when system property used at configuration time changes on disk"() { |
There was a problem hiding this comment.
💅 Should we also test that we reuse the cache if the system property is never read?
| outputContains "configuration cache cannot be reused because Gradle property 'foo' has changed." | ||
| } | ||
|
|
||
| def "invalidates cache when system property used at configuration time changes on disk"() { |
There was a problem hiding this comment.
💅 I would also add a test where a system property is set in the file, used only at execution time, to verify that the change to it is visible, while still getting a cache hit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #20969
Reviewing cheatsheet
Before merging the PR, comments starting with