feat: add macOS support to alloy role #418
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**Added:** - Introduced macOS (Darwin) support for installing and managing Alloy, including a dedicated `setup-Darwin.yml` task file leveraging Homebrew for package management and service control - Added macOS-specific handler to restart Alloy using Homebrew services - Defined Darwin-specific variables in `vars/Darwin.yml` for Homebrew tap, package, and default config path - Updated role metadata to declare macOS platform support **Changed:** - Updated documentation to mention macOS as a supported OS and specify Homebrew and `community.general` requirements - Modified deployment tasks to conditionally execute Linux-specific logic only on RedHat and Debian families, and add macOS-specific verification and setup - Adjusted handler logic to include macOS restart handler - Improved uninstall logic to stop Alloy and remove config on macOS, and uninstall via Homebrew when appropriate
|
|
Collaborator
|
Thanks for contributing and adding macOS support! I'm not a macOS user myself, so I can’t fully test it, but I did take the time to review your PR. From my perspective, it’s safe to merge since it doesn’t affect Before we merge, could you please update |
**Changed:** - Updated all Ansible register and fact variable names in the Alloy macOS setup task to use a double underscore prefix for consistency and to avoid naming conflicts - Changed the default value for `__alloy_config_path_default` to reference `__brew_prefix.stdout` instead of `brew_prefix.stdout` in Darwin-specific variables for consistency with task variable naming - Refactored logic throughout the Alloy Darwin setup to use the new variable names in all conditions, paths, and debug statements for clarity and maintainability
Contributor
Author
Sure thing, done! |
Contributor
Author
If it helps, here's the relevant snippet from the playbook I use: and the output from running it: |
Contributor
Author
Of course! I started to write it into one of my collections and quickly realized there was probably an existing collection that I could update instead. |
**Changed:** - Consolidated Alloy service start tasks into a single step, removing redundant sudo logic and user-level distinction to streamline service management - Updated service start and restart steps to use explicit return code checks for failure detection, improving error handling consistency - Simplified conditional logic to reduce complexity in service start and restart operations on Darwin systems **Removed:** - Eliminated separate sudo-based service start task and related conditionals to avoid unnecessary privilege escalation and duplication
voidquark
approved these changes
Sep 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added:
setup-Darwin.ymltask file leveraging Homebrew for package management and service control (as per https://grafana.com/docs/alloy/latest/set-up/install/macos/)vars/Darwin.ymlfor Homebrew tap, package, and default config pathChanged:
community.generalrequirements