browser: address frameLocator PR review comments
#5489
+78
−85
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Use ErrElementNotVisible sentinel error in stepIntoFrame - Add newPageWithIFrameSrcdoc test helper utility - Move FrameLocator type to locator.go for better organization
ankur22
requested changes
Dec 16, 2025
Contributor
ankur22
left a comment
There was a problem hiding this comment.
@pkalsi97 thanks for picking up this refactoring issue! 🙇
You've covered two of the comments from the PR review comments well.
I think you will need to revisit the test one though -- to do with the newPageWithIFrameSrcdoc function.
Also a nit: next time it would be a bit easier if each of those review comments were tackled in separate commits.
Author
|
@ankur22 Thanks for the review, I'll keep this in mind from now onwards! |
ankur22
approved these changes
Dec 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Address pending review comments from PR #5075
ErrElementNotVisiblesentinel error in stepIntoFrameFrameLocatortype tolocator.gofor better organizationWhy?
Follow-up from Issue #5129
Checklist
make check) and all pass.Checklist: Documentation (only for k6 maintainers and if relevant)
Please do not merge this PR until the following items are filled out.
Related PR(s)/Issue(s)
PR: #5075
Closes #5129