Skip to content

Conversation

@ankur22
Copy link
Contributor

@ankur22 ankur22 commented Dec 17, 2025

What?

Downgrading warning log to debug.

Why?

We're already handling the error when one occurs here, and it is propagated back to the user via the API they were calling when the error occurred. No need to also log a warning, which is confusing and causes noise in the terminal.

Checklist

  • I have performed a self-review of my code.
  • I have commented on my code, particularly in hard-to-understand areas.
  • I have added tests for my changes.
  • I have run linter and tests locally (make check) and all pass.

Checklist: Documentation (only for k6 maintainers and if relevant)

Please do not merge this PR until the following items are filled out.

  • I have added the correct milestone and labels to the PR.
  • I have updated the release notes: link
  • I have updated or added an issue to the k6-documentation: grafana/k6-docs#NUMBER if applicable
  • I have updated or added an issue to the TypeScript definitions: grafana/k6-DefinitelyTyped#NUMBER if applicable

Related PR(s)/Issue(s)

We're already handling the error when one occurs here, and it is
propagated back to the user via the API they were calling when the
error occurred.
@ankur22 ankur22 added this to the v1.5.0 milestone Dec 17, 2025
@ankur22 ankur22 marked this pull request as ready for review December 17, 2025 08:02
@ankur22 ankur22 requested a review from a team as a code owner December 17, 2025 08:02
@ankur22 ankur22 requested review from joanlopez and oleiade and removed request for a team December 17, 2025 08:03
@ankur22 ankur22 temporarily deployed to azure-trusted-signing December 17, 2025 08:08 — with GitHub Actions Inactive
@ankur22 ankur22 temporarily deployed to azure-trusted-signing December 17, 2025 08:10 — with GitHub Actions Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants