Skip to content

feat: Add UI proxy TLS config #20032

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

feat: Add UI proxy TLS config #20032

wants to merge 3 commits into from
+103 −6

Conversation

@attilaolah
Copy link

@attilaolah attilaolah commented Nov 26, 2025 •
edited
Loading

What this PR does / why we need it:

Which issue(s) this PR fixes:
Fixes #20031

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@CLAassistant
Copy link

CLAassistant commented Nov 26, 2025 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@pull-request-size pull-request-size bot added size/L and removed size/M labels Nov 26, 2025
@attilaolah attilaolah force-pushed the issue-20031 branch 2 times, most recently from d639447 to 9db313f Compare November 26, 2025 12:26
@attilaolah attilaolah marked this pull request as ready for review November 26, 2025 15:18
@attilaolah attilaolah requested a review from a team as a code owner November 26, 2025 15:18
@attilaolah
Copy link
Author

attilaolah commented Nov 26, 2025

Rebased, fixed the docs with make docs and re-formatted, apparently gofumpt didn't do a good enough job.

@attilaolah
Copy link
Author

attilaolah commented Nov 26, 2025 •
edited
Loading

I don't understand why check / testPackages (pkg/dataobj) is failing though. It passes for me locally.

@JStickler
Copy link
Contributor

JStickler commented Nov 28, 2025

I don't understand why check / testPackages (pkg/dataobj) is failing though.

I think it's probably either a race condition or a network issue; it's a flaky test that randomly fails, but usually passes when you run it again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

size/L

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

UI not working when TLS/mTLS is enabled

3 participants

@attilaolah @CLAassistant @JStickler