vParquet5: fix issues related to integer dedicated columns #5716
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fa0e2b9 to
c593c83
Compare
mdisibio
reviewed
Oct 9, 2025
|
|
||
| func addHash(s *string, hash uint64) uint64 { | ||
| func addHashStr(s *string, hash uint64) uint64 { | ||
| if s == nil { |
Contributor
There was a problem hiding this comment.
I know this wasn't changed and it must be working, but it seems like a potential bug to me. If we skip nils, then do these layouts have the same hash?
(1) String01: foo, String02: nil
(2) String01: nil, String02: foo
In both cases it yields the same result: hash(foo)? One fix is to add a separator in between like AddUint64(prime number), and always add it even if nil.
Then they become distinct:
(1) foo, sep, sep
(2) sep, foo, sep
mdisibio
approved these changes
Oct 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
This addresses two issues with dedicated attribute columns with integer values introduced in
vParquet5-preview2. The functionsDedicatedColumns.Validate()andresourceSpanHash()were not taking taking the added integer columns into account.Which issue(s) this PR fixes:
Fixes issues introduced by #5639
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]