fix(GRA-1201): remove "local network"#280
Merged
Merged
Conversation
0xdcarns
suggested changes
Feb 23, 2023
Contributor
0xdcarns
left a comment
There was a problem hiding this comment.
fix conflicts, also will wait on pairing with backend to merge
5061404 to
e4f2250
Compare
Contributor
|
I ran this branch a few times and did a shift reload and I cannot get the local range to leave in the node details. |
Contributor
Author
|
updated |
theguy951357
approved these changes
Feb 24, 2023
Contributor
theguy951357
left a comment
There was a problem hiding this comment.
local range and islocalnetwork is gone
no new Ui bugs
pass
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TESTING STEPS: