build(cmake): fix compiler detection logic#70
Conversation
the condition wrongly matched LLVMFlang (flang-new), which does not support -Mbackslash and -Mallocatable=03. https://cmake.org/cmake/help/v3.24/variable/CMAKE_LANG_COMPILER_ID.html
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #70 +/- ##
==========================================
- Coverage 69.79% 69.78% -0.01%
==========================================
Files 64 64
Lines 8618 8639 +21
Branches 2579 2586 +7
==========================================
+ Hits 6015 6029 +14
- Misses 782 783 +1
- Partials 1821 1827 +6 ☔ View full report in Codecov by Sentry. |
|
Note that flang-new 18.1.8 does not compile MCTC because it does not support polymorphic types yet. |
|
I've also just come across this after trying to update to the very latest dftd4.
Yes, those options are not needed/default with
It was building fine with One has to add |
the condition wrongly matched LLVMFlang (flang-new), which does not support
-Mbackslashand-Mallocatable=03.https://cmake.org/cmake/help/v3.24/variable/CMAKE_LANG_COMPILER_ID.html