Skip to content

Implement resuming behaviour #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Flegyas merged 5 commits into from
Jan 10, 2022
Merged

Implement resuming behaviour #25

Flegyas merged 5 commits into from
Jan 10, 2022

Conversation

@lucmos
Copy link
Member

@lucmos lucmos commented Jan 9, 2022

@lucmos lucmos requested a review from Flegyas January 9, 2022 14:29
@lucmos lucmos mentioned this pull request Jan 10, 2022
Merged
@Flegyas
Copy link
Member

Flegyas commented Jan 10, 2022 •
edited
Loading

The current resume configuration seems a little too cumbersome.

I'd suggest something like these restore modes:

  • new model, new run = none/new/null

  • old model, old run = continue

  • old model, new run = hotstart

  • new model, old run = madness

restore:
    ckpt_or_run_path: optional
    mode: none/continue/hotstart

@Flegyas Flegyas merged commit 78b3d6c into develop Jan 10, 2022
@Flegyas Flegyas deleted the feature/resume branch January 10, 2022 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Flegyas Flegyas Awaiting requested review from Flegyas

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@lucmos @Flegyas