fix(core): preserve input server_params by using get() instead of pop()#66
Conversation
|
@fblacuttgottret-godaddy thanks a lot for proposing a fix for this. Unfortunately it's not working. We remove the transport key because we pass serverparams directly to the client constructor and it doesnt support the "transport" kwarg. Check the failing test for more details. What could work would be to copy the serverparams object and pop the transport from the copy instead of the original. |
BREAKING CHANGE: None - this is a backwards-compatible fix The previous implementation modified the input dictionary by removing the 'transport' key, causing issues for applications reusing the same config. Fixes grll#65
9884025 to
61eadb0
Compare
ah makes sense, that's why it was doing the pop in the first place. updated to make a copy and keep pop() |
BREAKING CHANGE: None - this is a backwards-compatible fix The previous implementation modified the input dictionary by removing the 'transport' key, causing issues for applications reusing the same config. Fixes grll#65
BREAKING CHANGE: None - this is a backwards-compatible fix
The previous implementation modified the input dictionary by removing the 'transport' key, causing issues for applications reusing the same config.
Fixes #65