[Backport to v1.66.x] Add templating and support for Python 3.13 (#37643) #37802
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR adds templating for Python versions and updates the maximum supported Python version to 3.13. The following major changes related to templating are added: - Minimum supported Python version and list of supported versions in `setup.py` are fetched using new template generated files called `python_version.py` - Dockerfiles for the different Python Linux builds are now template generated. - The "Supported Python Versions" section from READMEs of ancillary and main packages have been removed Note: All the `python_version.py` files and Linux build `Dockerfiles` except `tools/dockerfile/grpc_artifact_python_linux_armv7/Dockerfile` in the PR are generated from the respective templates. Further non-templated additions to add support for Python 3.13: - install scripts and artifacts for windows, macos and linux are added manually. Later, these can be templated as well. - updated cython bounds to 3.x - updated twine version to solve [cgi module import error](pypa/twine#1046) - the twine update introduces a dependency on cryptography>=2.0. But the cryptography package doesn't support 32-bit Linux images and hence `twine check` has been disabled for x86 manylinux and x86 musllinux artifacts. Closes grpc#37643 PiperOrigin-RevId: 678954495
|
All failures are unrelated. Going ahead and merging. |
gnossen
reviewed
Sep 26, 2024
| # NOTE: git>=2.46 allows leading paths like third_party/* to include all subdirectories | ||
| # current docker base images use git versions lower than 2.46 and hence require separate configs for each submodule | ||
| RUN git config --global --add safe.directory /var/local/jenkins/grpc | ||
| RUN git config --global --add safe.directory /var/local/jenkins/grpc/.git |
There was a problem hiding this comment.
This is not an immediate blocker, but please take an action item to remove the explicit enumeration of third-party modules. This is going to make it significantly more difficult to add a third-party module in the future.
There was a problem hiding this comment.
This change will only be needed on the master branch.
gnossen
approved these changes
Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds templating for Python versions and updates the maximum supported Python version to 3.13. The following major changes related to templating are added:
setup.pyare fetched using new template generated files calledpython_version.pyNote: All the
python_version.pyfiles and Linux buildDockerfilesexcepttools/dockerfile/grpc_artifact_python_linux_armv7/Dockerfilein the PR are generated from the respective templates.Further non-templated additions to add support for Python 3.13:
twine checkhas been disabled for x86 manylinux and x86 musllinux artifacts.Closes #37643
PiperOrigin-RevId: 678954495