[XdsInteropClient] Remove incorrect behavior around keep-open #38613
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markdroth
approved these changes
Jan 29, 2025
yashykt
added a commit
to yashykt/grpc
that referenced
this pull request
Jan 29, 2025
…8613) Based on the [spec](https://github.com/grpc/grpc/blob/master/doc/xds-test-descriptions.md#server) and the [reference Java implementation](https://github.com/grpc/grpc-java/blob/master/interop-testing/src/main/java/io/grpc/testing/integration/XdsTestClient.java), it's the server that needs to honor the "keep-open" behavior and not the client. (I'm not changing the server's behavior in this PR, since we are not using C++ servers and instead using Java servers for the concerned tests.) Closes grpc#38613 COPYBARA_INTEGRATE_REVIEW=grpc#38613 from yashykt:FixXdsInteropClientBehavior 99556ba PiperOrigin-RevId: 720999079
yashykt
added a commit
to yashykt/grpc
that referenced
this pull request
Jan 29, 2025
…8613) Based on the [spec](https://github.com/grpc/grpc/blob/master/doc/xds-test-descriptions.md#server) and the [reference Java implementation](https://github.com/grpc/grpc-java/blob/master/interop-testing/src/main/java/io/grpc/testing/integration/XdsTestClient.java), it's the server that needs to honor the "keep-open" behavior and not the client. (I'm not changing the server's behavior in this PR, since we are not using C++ servers and instead using Java servers for the concerned tests.) Closes grpc#38613 COPYBARA_INTEGRATE_REVIEW=grpc#38613 from yashykt:FixXdsInteropClientBehavior 99556ba PiperOrigin-RevId: 720999079
yashykt
added a commit
to yashykt/grpc
that referenced
this pull request
Jan 29, 2025
…8613) Based on the [spec](https://github.com/grpc/grpc/blob/master/doc/xds-test-descriptions.md#server) and the [reference Java implementation](https://github.com/grpc/grpc-java/blob/master/interop-testing/src/main/java/io/grpc/testing/integration/XdsTestClient.java), it's the server that needs to honor the "keep-open" behavior and not the client. (I'm not changing the server's behavior in this PR, since we are not using C++ servers and instead using Java servers for the concerned tests.) Closes grpc#38613 COPYBARA_INTEGRATE_REVIEW=grpc#38613 from yashykt:FixXdsInteropClientBehavior 99556ba PiperOrigin-RevId: 720999079
yashykt
added a commit
to yashykt/grpc
that referenced
this pull request
Jan 29, 2025
…8613) Based on the [spec](https://github.com/grpc/grpc/blob/master/doc/xds-test-descriptions.md#server) and the [reference Java implementation](https://github.com/grpc/grpc-java/blob/master/interop-testing/src/main/java/io/grpc/testing/integration/XdsTestClient.java), it's the server that needs to honor the "keep-open" behavior and not the client. (I'm not changing the server's behavior in this PR, since we are not using C++ servers and instead using Java servers for the concerned tests.) Closes grpc#38613 COPYBARA_INTEGRATE_REVIEW=grpc#38613 from yashykt:FixXdsInteropClientBehavior 99556ba PiperOrigin-RevId: 720999079
yashykt
added a commit
to yashykt/grpc
that referenced
this pull request
Jan 29, 2025
…8613) Based on the [spec](https://github.com/grpc/grpc/blob/master/doc/xds-test-descriptions.md#server) and the [reference Java implementation](https://github.com/grpc/grpc-java/blob/master/interop-testing/src/main/java/io/grpc/testing/integration/XdsTestClient.java), it's the server that needs to honor the "keep-open" behavior and not the client. (I'm not changing the server's behavior in this PR, since we are not using C++ servers and instead using Java servers for the concerned tests.) Closes grpc#38613 COPYBARA_INTEGRATE_REVIEW=grpc#38613 from yashykt:FixXdsInteropClientBehavior 99556ba PiperOrigin-RevId: 720999079
yashykt
added a commit
that referenced
this pull request
Jan 30, 2025
#38628) Backport #381613 to v1.70.x Based on the [spec](https://github.com/grpc/grpc/blob/master/doc/xds-test-descriptions.md#server) and the [reference Java implementation](https://github.com/grpc/grpc-java/blob/master/interop-testing/src/main/java/io/grpc/testing/integration/XdsTestClient.java), it's the server that needs to honor the "keep-open" behavior and not the client. (I'm not changing the server's behavior in this PR, since we are not using C++ servers and instead using Java servers for the concerned tests.)
yashykt
added a commit
that referenced
this pull request
Jan 30, 2025
#38629) Backport #38613 to v1.69.x Based on the [spec](https://github.com/grpc/grpc/blob/master/doc/xds-test-descriptions.md#server) and the [reference Java implementation](https://github.com/grpc/grpc-java/blob/master/interop-testing/src/main/java/io/grpc/testing/integration/XdsTestClient.java), it's the server that needs to honor the "keep-open" behavior and not the client. (I'm not changing the server's behavior in this PR, since we are not using C++ servers and instead using Java servers for the concerned tests.)
yashykt
added a commit
that referenced
this pull request
Jan 30, 2025
#38630) Backport #38613 to v1.68.x Based on the [spec](https://github.com/grpc/grpc/blob/master/doc/xds-test-descriptions.md#server) and the [reference Java implementation](https://github.com/grpc/grpc-java/blob/master/interop-testing/src/main/java/io/grpc/testing/integration/XdsTestClient.java), it's the server that needs to honor the "keep-open" behavior and not the client. (I'm not changing the server's behavior in this PR, since we are not using C++ servers and instead using Java servers for the concerned tests.)
yashykt
added a commit
that referenced
this pull request
Jan 30, 2025
#38631) Backport #38613 to v1.67.x Based on the [spec](https://github.com/grpc/grpc/blob/master/doc/xds-test-descriptions.md#server) and the [reference Java implementation](https://github.com/grpc/grpc-java/blob/master/interop-testing/src/main/java/io/grpc/testing/integration/XdsTestClient.java), it's the server that needs to honor the "keep-open" behavior and not the client. (I'm not changing the server's behavior in this PR, since we are not using C++ servers and instead using Java servers for the concerned tests.)
yashykt
added a commit
that referenced
this pull request
Jan 30, 2025
#38632) Backport #38613 to v1.66.x Based on the [spec](https://github.com/grpc/grpc/blob/master/doc/xds-test-descriptions.md#server) and the [reference Java implementation](https://github.com/grpc/grpc-java/blob/master/interop-testing/src/main/java/io/grpc/testing/integration/XdsTestClient.java), it's the server that needs to honor the "keep-open" behavior and not the client. (I'm not changing the server's behavior in this PR, since we are not using C++ servers and instead using Java servers for the concerned tests.)
paulosjca
pushed a commit
to paulosjca/grpc
that referenced
this pull request
Feb 20, 2025
…8613) Based on the [spec](https://github.com/grpc/grpc/blob/master/doc/xds-test-descriptions.md#server) and the [reference Java implementation](https://github.com/grpc/grpc-java/blob/master/interop-testing/src/main/java/io/grpc/testing/integration/XdsTestClient.java), it's the server that needs to honor the "keep-open" behavior and not the client. (I'm not changing the server's behavior in this PR, since we are not using C++ servers and instead using Java servers for the concerned tests.) Closes grpc#38613 COPYBARA_INTEGRATE_REVIEW=grpc#38613 from yashykt:FixXdsInteropClientBehavior 99556ba PiperOrigin-RevId: 720999079
yashykt
added a commit
to yashykt/grpc
that referenced
this pull request
Jun 16, 2025
…8613) Based on the [spec](https://github.com/grpc/grpc/blob/master/doc/xds-test-descriptions.md#server) and the [reference Java implementation](https://github.com/grpc/grpc-java/blob/master/interop-testing/src/main/java/io/grpc/testing/integration/XdsTestClient.java), it's the server that needs to honor the "keep-open" behavior and not the client. (I'm not changing the server's behavior in this PR, since we are not using C++ servers and instead using Java servers for the concerned tests.) Closes grpc#38613 COPYBARA_INTEGRATE_REVIEW=grpc#38613 from yashykt:FixXdsInteropClientBehavior 99556ba PiperOrigin-RevId: 720999079
yashykt
added a commit
that referenced
this pull request
Jun 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on the spec and the reference Java implementation, it's the server that needs to honor the "keep-open" behavior and not the client.
(I'm not changing the server's behavior in this PR, since we are not using C++ servers and instead using Java servers for the concerned tests.)